Developing (v7+)

Bug in register.php: Registration doesn't work

Permalink 2 users found helpful January 27, 2010 at 4:24 AM

Hi

Today is my C5 problem day ;) I have following problem - first, what have I done:

- copy the single page "register.php" from "concrete\single_pages" to "\single_pages"
- edited the singe page "register.php"
- I set in the Dashboard: "Registration is enabled, email must be validated." and "Solving a CAPTCHA is required to register."

the problem:

- The registration form doesn't work. I don't know why - the file /concrete/controllers/register.php will be called but no error appears...

You can test it here:
http://www.around.ch/index.php/register/...
http://www.around.ch/index.php/login/...

What have i tested:
- Without registration restrictions only "Registration is enabled"
- With the original single page file

My C5 Version is:
- 5.3.3.1 (First Version was 5.2)

Thanks for any help.

greetings

marius

marius replied on Jan 27, 2010 at 4:36 am Permalink Reply

I Think the problem is here:

if($success) { 
   switch($success) { 
      case "registered": 
         ?>
         <p><strong><?php echo $successMsg ?></strong><br/><br/>
         <a href="<?php echo $this->url('/')?>"><?php echo t('Return to Home')?></a>
         <?php  
      break;
      case "validate": 
         ?>
         <p><?php echo $successMsg[0] ?></p>
         <p><?php echo $successMsg[1] ?></p>
         <p><a href="<?php echo $this->url('/')?>"><?php echo t('Return to Home')?></a></p>
         <?php 
      break;

Viewing 15 lines of 22 lines. View entire code block.

 
if($success) { 
   switch($success) { 
      case "registered": 
         ?>
         <p><strong><?php echo $successMsg ?></strong><br/><br/>
         <a href="<?php echo $this->url('/')?>"><?php echo t('Return to Home')?></a>
         <?php  
      break;
      case "validate": 
         ?>
         <p><?php echo $successMsg[0] ?></p>
         <p><?php echo $successMsg[1] ?></p>
         <p><a href="<?php echo $this->url('/')?>"><?php echo t('Return to Home')?></a></p>
         <?php 
      break;
      case "pending":
         ?>
         <p><?php echo $successMsg ?></p>
         <p><a href="<?php echo $this->url('/')?>"><?php echo t('Return to Home')?></a></p>
            <?php 
      break;
   }

The variable $success will not be set.

marius replied on Jan 27, 2010 at 4:56 am Permalink Reply

LoL ok now i have found the problem.

I open the \controller\register.php and look at the line 214.

There will be the var $registerData['errors'] with print_r ($registerData['errors']); i look in to the array. The errors in the array was:

Array ( [0] => Incorrect image validation code. Please check the image and re-enter the letters or numbers as necessary. 
[1] => A password must be between 5 and 64 characters )

Now with a longer PW it works. Now i must bring the errors on the registration page...

Leap replied on Feb 2, 2010 at 6:10 am Permalink Reply

By the look of your example pages in the first post you solved it?

How did you do it because I have the exact same problem...

Thank you in advance for your reply!

Remo replied on Feb 2, 2010 at 6:36 am Permalink Reply

yes, I think you'll have the same problem with /login if you enter an incorrect password..

You won't see the error unless you use the default theme.

Remo replied on Feb 2, 2010 at 6:38 am Permalink Reply

oh I forgot to post a solution (:

<? if (isset($error)) { ?>
      <? 
      if ($error instanceof Exception) {
         $_error[] = $error->getMessage();
      } else if ($error instanceof ValidationErrorHelper) {
         $_error = array();
         if ($error->has()) {
            $_error = $error->getList();
         }
      } else {
         $_error = $error;
      }
      if (count($_error) > 0) {
         ?>
         <div class="message error">

Viewing 15 lines of 26 lines. View entire code block.

 
         <? if (isset($error)) { ?>
      <? 
      if ($error instanceof Exception) {
         $_error[] = $error->getMessage();
      } else if ($error instanceof ValidationErrorHelper) {
         $_error = array();
         if ($error->has()) {
            $_error = $error->getList();
         }
      } else {
         $_error = $error;
      }
 
      if (count($_error) > 0) {
         ?>
         <div class="message error">
         <strong><?=t('The following errors occurred when attempting to process your request:')?></strong>
         <ul>
         <? foreach($_error as $e) { ?><li><?=$e?></li><? } ?>
         </ul>
         </div>
      <? 
      }
   }
 
   if (isset($message)) { ?>
      <div class="message success"><?=$message?></div>
   <? } ?>

copied from concrete/themes/core/dashboard.php

marius replied on Feb 2, 2010 at 7:31 am Permalink Reply

oh sorry forgot to post the solution too. Use the "same" like remo.

if (isset($error)) {   
      ?><span class="ccm-error">> Es sind folgende Fehler aufgetreten:</span><?php
    if ($error instanceof Exception) { 
        $_error[] = $error->getMessage(); 
    } else if ($error instanceof ValidationErrorHelper) {  
        $_error = $error->getList(); 
    } else if (is_array($error)) { 
        $_error = $error; 
    } else if (is_string($error)) { 
        $_error[] = $error; 
    } 
        ?> 
        <ul class="ccm-error"> 
        <?php  foreach($_error as $e) { ?><li><?php echo $e?></li><?php  } ?> 
        </ul>

Viewing 15 lines of 17 lines. View entire code block.

 
  if (isset($error)) {   
      ?><span class="ccm-error">> Es sind folgende Fehler aufgetreten:</span><?php
    if ($error instanceof Exception) { 
        $_error[] = $error->getMessage(); 
    } else if ($error instanceof ValidationErrorHelper) {  
        $_error = $error->getList(); 
    } else if (is_array($error)) { 
        $_error = $error; 
    } else if (is_string($error)) { 
        $_error[] = $error; 
    } 
 
        ?> 
        <ul class="ccm-error"> 
        <?php  foreach($_error as $e) { ?><li><?php echo $e?></li><?php  } ?> 
        </ul> 
    <?php   
}

Leap replied on Feb 2, 2010 at 7:33 am Permalink Reply

Thank you both for the replies!
It works like a charm now!

pakigreenl replied on Jun 15, 2010 at 3:49 pm Permalink Reply

I've had the same problem. Thanks for the code but where do I insert that? I'm building my first C5 site and am feeling my way through this. Thanks.

marius replied on Jun 15, 2010 at 5:48 pm Permalink Reply

Hi

Copy the register.php from \concrete\single_pages to \single_pages.

Copy befor line 6 (if($success) {)following code:

if (isset($error)) {   
      ?><span class="ccm-error">> Es sind folgende Fehler aufgetreten:</span><?php
    if ($error instanceof Exception) { 
        $_error[] = $error->getMessage(); 
    } else if ($error instanceof ValidationErrorHelper) {  
        $_error = $error->getList(); 
    } else if (is_array($error)) { 
        $_error = $error; 
    } else if (is_string($error)) { 
        $_error[] = $error; 
    } 
        ?> 
        <ul class="ccm-error"> 
        <?php  foreach($_error as $e) { ?><li><?php echo $e?></li><?php  } ?> 
        </ul>

Viewing 15 lines of 17 lines. View entire code block.

 
  if (isset($error)) {   
      ?><span class="ccm-error">> Es sind folgende Fehler aufgetreten:</span><?php
    if ($error instanceof Exception) { 
        $_error[] = $error->getMessage(); 
    } else if ($error instanceof ValidationErrorHelper) {  
        $_error = $error->getList(); 
    } else if (is_array($error)) { 
        $_error = $error; 
    } else if (is_string($error)) { 
        $_error[] = $error; 
    } 
 
        ?> 
        <ul class="ccm-error"> 
        <?php  foreach($_error as $e) { ?><li><?php echo $e?></li><?php  } ?> 
        </ul> 
    <?php   
}

pakigreenl replied on Jun 16, 2010 at 7:51 am Permalink Reply

Thanks, I will try that.

pakigreenl replied on Jun 17, 2010 at 7:50 am Permalink Reply

Thanks that worked but i've lost most of the german i've learned could you translate the "Es sind folgende Fehler aufgetreten:" please. Thanks for all your help.

pakigreenl replied on Jun 17, 2010 at 7:53 am Permalink Reply

I believe it reads: "The following error has occurred:"
Please confirm.Thanks.

marius replied on Jun 17, 2010 at 10:38 pm Permalink Reply

Jeahh or "The following errors occurred when attempting to process your request"

LotosNile replied on Sep 7, 2011 at 12:44 pm Permalink Reply

I'm having the same problem. For some reason the code you provided breaks my registration process. I followed these direction, but it still just breaks my code.

Forums

Developing (v7+)

Bug in register.php: Registration doesn't work

Code

Post Reply

Delete Post

Mark Post as Spam

Destroy Spammer

Sign In?